Remove DOMException dev dependency

Node.js v18+ has one built-in, which suffices for our purpose of running web platform tests.
jsdom · Nov 12, 2023 · 6aa56a7 · 6aa56a7
1 parent 6c6fb17
commit 6aa56a7
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 17 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -19,7 +19,6 @@
     "@domenic/eslint-config": "^3.0.0",
     "benchmark": "^2.1.4",
     "c8": "^8.0.1",
-    "domexception": "^4.0.0",
     "esbuild": "^0.19.5",
     "eslint": "^8.53.0",
     "webidl2js": "^17.1.0"

diff --git a/test/testharness.js b/test/testharness.js
@@ -34,8 +34,8 @@ module.exports = {
   },
 
   assert_throws_js(errorConstructor, func) {
-    // Don't bother testing the errorConstructor since that brings in tricky realm issues.
-    assert.throws(func);
+    // Don't pass errorConstructor itself since that brings in tricky realm issues.
+    assert.throws(func, errorConstructor.name);
   },
 
   assert_unreached() {

diff --git a/test/web-platform.js b/test/web-platform.js
@@ -4,7 +4,6 @@ const path = require("path");
 const fs = require("fs");
 const vm = require("vm");
 const assert = require("assert");
-const DOMException = require("domexception");
 const { directlyRunnableTests, resourceDependentTests } = require("../scripts/get-latest-platform-tests.js");
 const testharness = require("./testharness.js");