Fix dev-dependencies and test files requires #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React was setup before Jest, so tests were never executed when I initially ported the project to npm and wally. React could not even depend on the jest packages. This PR is a first step towards making the test suite run: it corrects a lot of the requires in test files and also define each dev-dependency. This PR also enables the `@jsdotlua/react-noop-renderer` and `@jsdotlua/jest-react` to now be published!
grilme99
approved these changes
Dec 4, 2024
How to publish [jest-react and react-noop-renderer] to wally-index? I found:
- name: Publish jest-react to wally
run: wally publish --project-path build/wally/jest-react
- name: Publish react-noop-renderer
run: wally publish --project-path build/wally/react-noop-renderer |
westurner
added a commit
to westurner/react-lua
that referenced
this pull request
Mar 23, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #19
React was setup before Jest, so tests were never executed when I initially ported the project to npm and wally. React could not even depend on the jest packages.
This PR is a first step towards making the test suite run: it corrects a lot of the requires in test files and also define each dev-dependency.
This PR also enables the
@jsdotlua/react-noop-rendererand@jsdotlua/jest-reactto now be published!