Skip to content

Fab button #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2019
Merged

Fab button #743

merged 5 commits into from
Jun 1, 2019

Conversation

martinfrances107
Copy link
Contributor

@martinfrances107 martinfrances107 commented May 20, 2019 •
edited
Loading

Issue

#741

As per the issue.. This is a minor patch swapping material-ui elements of the form

<Button variant="fab" xyx >
  <IconButton>
</Button>

to the new form

<Fab xyz >
  <IconButton>
</Fab>

dawehner
dawehner approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@dawehner dawehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks perfect

@martinfrances107
Copy link
Contributor Author

Maybe we have a test instability -- I cant account for the first test failure ... I merged in the latest changes and everything now passes...

nothing in the merge was significant.

@martinfrances107 martinfrances107 merged commit c9854f5 into jsdrupal:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawehner dawehner dawehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinfrances107 @dawehner