Write '*' as '_' on the filesystem #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be _, not "wildcard" imho |
|
@tox2ik agreed, thanks for the feedback! |
jsha
changed the title
|
Thanks so much for the patch! I had been meaning to get back to you on this with the feedback that "wildcard" didn't feel right, but I was stuck on proposing a better alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to use minica to issue some wildcard self-signed certificates on our Windows machine, but ran into the issue that Windows doesn't support a '*' character on it's filesystem.
This patch ensures that folders created with the char '*' are written out as 'wildcard'.
Not a go developer so unsure if this is the best approach :)