Make read and write access to modified properties synchronized #568
Conversation
… is both access from background and foreground threads. Only synchronization assures that the changes are visible immediately.
|
Good spot, thanks - as to the means, it's brute-force, but for what we're doing it's a simple and maintainable solution, and so a good choice for this! TBH the codebase will be full of this sort of thing - some of the code dates back to 2006, when I somehow knew even less about building software, and when the threading model for IDEA plugins was very, very different. JetBrains have done sterling work in making the IDE more responsive since then, but it has lead to a lot of the code being called in a very different manner than it was designed for. TL;DR mea culpa 😬 |
|
@jshiell - this is no place for a "mea culpa"! I'm happy that this plugin exists, and I'm happy to lend a helping hand when I can. With the plugin I maintain (the AsciiDoc plugin) I often find myself in a similar spot that the evolving JetBrains APIs are a challenge now and then (including the multithreading). |
When working on the other PR, I found that the reset via the AWT thread and the blocking by the background thread are not synchronized and not volatile. This could result in a situation that one thread sets some information that is then not visible for another thread. This PR changes that - please let me know if I chose the right means.