refactor: update contentDisposition function with ES6+ syntax for clarity #60
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity - Replaced �ar with const for immutable values. - Used default parameters and destructuring for options to simplify handling. - Removed redundant variable initialization, enhancing readability. This change modernizes the code, making it more concise and consistent with current JavaScript standards.
Phillip9587
reviewed
Nov 12, 2024
Comment on lines
-143
to
+144
| function contentDisposition (filename, options) { | ||
| var opts = options || {} | ||
|
|
||
| // get type | ||
| var type = opts.type || 'attachment' | ||
| function contentDisposition (filename, options = {}) { | ||
| const { type = 'attachment', fallback } = options |
There was a problem hiding this comment.
@Ayoub-Mabrouk This code does not handle passing null as options but the previous code did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: update contentDisposition function with ES6+ syntax for clarity
varwithconstfor immutable values.optionsto simplify handling.This change modernizes the code, making it more concise and consistent with current JavaScript standards.