Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deep-equal with dequal #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojtekmaj
Copy link

This PR replaces deep-equal with dequal, an alternative package with 0 dependencies (as opposed to 49: https://npmgraph.js.org/?q=deep-equal).

This PR replaces deep-equal with dequal, an alternative package with 0 dependencies (as opposed to 49: https://npmgraph.js.org/?q=deep-equal).
@wesleytodd
Copy link
Member

We do not typically like to take package swaps for this reason. Is there any functional reason to pursue this change? In this specific case we would decline this PR anyway because the package currently supports node's older than 6. Even when we move past that hurdle, I don't see a reason to change this dependency based solely on how many transitives it brings in.

@wojtekmaj
Copy link
Author

wojtekmaj commented Jul 16, 2024

Since it's a devDependency, it's only going to affect the development environment. No user-facing code has been altered. I don't think any sane person would develop this package using Node.js 6.

The motivation for this change is to make this repo lighter and faster to install.

@wesleytodd
Copy link
Member

All our dev deps need to run in CI, and CI runs in older versions. As for faster to install, can you run some benchamrks and show how much difference this makes? Please do so with both cold and warm cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants