-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable compression for TTF font format #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for your contribution! Please make sure to follow the instructions for making a contribution in the readme https://github.com/jshttp/mime-db/blob/master/README.md#contributing
Notably this PR is modifying the wrong file.
In addition, please be sure to include a source link as well that talks about this mime being compressible 👍
f03439d
to
641f6cb
Compare
I made the corrections. Is that ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Ref: * jshttp/mime-db#169 * developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/webfont-optimization#reducing_font_size_with_compression
* Bump server-config-test to 1.2.1 * Additional compression method added for gzip (h5bp#236) * Fixed description for SSL session cache & timeout (h5bp#237) * Add `font/ttf` & `font/eot` to compressible mime-types list (h5bp#242) Ref: * jshttp/mime-db#169 * developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/webfont-optimization#reducing_font_size_with_compression * Improve HSTS documentation Ref: h5bp/server-configs-apache#196 * Stricter default for Referrer Policy Ref: h5bp/server-configs-apache#204 * Add funding file * Rename no-transform.conf file to content_transformation.conf Align with other files and with Apache struct Co-authored-by: Léo Colombaro <git@colombaro.fr> Co-authored-by: Jogendra Kumar <39511714+jkumar-roambee@users.noreply.github.com> Co-authored-by: Rahil <54960886+plethorahil@users.noreply.github.com> Co-authored-by: minusf <minusf@gmail.com>
TTF formats are not compressed by default. I think compression should be enabled so that others compression libraries which rely on this db can enable the font/ttf compression by default.