Add m4b as a type of audio/mp4 #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is commonly used for audiobooks
From the linked doc |
Add a comma missed in previous commit
|
Oops. I kept double-checking the lines I added for JSON errors but forgot to check the line above. Iʼm still having computer issues and canʼt run complicated tests right now but |
|
It seems valid to me, and the coverage is fickle and has been removed in a few of our repos. It is not necessary and once the window for reviews (I think 2 days) is up we can merge this. |
Yep, thatʼs the part Iʼm using as a citation. If that isnʼt good Iʼm sure I could find other sources. |
wesleytodd
approved these changes
Jan 16, 2025
bjohansebas
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this change on the GitHub website; if there are any tests to run I did not see information about them and did not run them.