Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - pre-commit integration & links #39

Closed
Laleee opened this issue Dec 7, 2022 · 4 comments · Fixed by #43
Closed

Feature request - pre-commit integration & links #39

Laleee opened this issue Dec 7, 2022 · 4 comments · Fixed by #43
Assignees

Comments

@Laleee
Copy link

Laleee commented Dec 7, 2022

Feature request

I realy like this library and find that it has some features that are missing in the pydocstyle. 🎉

Feature 1 🚀

Since many users automate linters, it would be nice to have support for the pre-commit. :)

Feature 2 🚀

When path to a file is displayed, it would be nice if it was a link to the specific line (like in pydocstyle). I'm using PyCharm if that's of any relevance.

@jshwi
Copy link
Owner

jshwi commented Dec 8, 2022

Hi @Laleee, thank you for the positive feedback

I'll like to have a look at this, feature 2 is a really good idea, it won't be hard to implement. I should be able to put that together pretty quickly

I'll look at feature 1 pre-commit integration too, once I complete 2

Thank you for helping improve this package!

@jshwi jshwi mentioned this issue Dec 8, 2022
@jshwi jshwi self-assigned this Dec 8, 2022
jshwi added a commit that referenced this issue Dec 9, 2022
Added .pre-commit-hooks.yaml
@jshwi jshwi linked a pull request Dec 9, 2022 that will close this issue
@jshwi jshwi closed this as completed in #43 Dec 9, 2022
@jshwi
Copy link
Owner

jshwi commented Dec 9, 2022

1 and 2 should be all good, if anything else comes to mind please don't hesitate to let me know, cheers!

@Laleee
Copy link
Author

Laleee commented Dec 9, 2022

Hi @jshwi,

Just wanted to confirm that everything works as expected.

Great work!

@jshwi
Copy link
Owner

jshwi commented Dec 10, 2022

Awesome! thanks for confirming @Laleee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants