Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] use stable and oldstable identifiers #187

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[ci] use stable and oldstable identifiers #187

merged 2 commits into from
Sep 25, 2023

Conversation

jsimonetti
Copy link
Owner

No description provided.

jsimonetti and others added 2 commits September 25, 2023 17:10
@jsimonetti
[ci] use stable and oldstable identifiers
61e977d 
Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
@jsimonetti
Merge branch 'master' into gotest
45cc129
@jsimonetti jsimonetti merged commit ba8be0e into master Sep 25, 2023
10 checks passed
@jsimonetti jsimonetti deleted the gotest branch September 25, 2023 15:16
@SuperQ
Copy link
Contributor

SuperQ commented Nov 27, 2023

I would actually recommend keeping the previous style. The Go modules go directive specifies a minimum version need. So in order to test properly from the current version (1.18) the matrix would need to be 1.18.x -> 1.21.x inclusive.

@jsimonetti
Copy link
Owner Author

Hmm, you have a point. It's a bit more work maintaining, but at least the tests are explicit and test the correct things.

jsimonetti added a commit that referenced this pull request Nov 27, 2023
@jsimonetti
Revert #187
74450cb 
Using an explicit matrix, makes sure the required version of the module
can be tested.

Signed-off-by: Jeroen Simonetti <jeroen@simonetti.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsimonetti @SuperQ