feat: add test to reproduce #605 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## jsjoeio-fix-ssr-before #7 +/- ##
==========================================================
Coverage ? 100.00%
==========================================================
Files ? 15
Lines ? 221
Branches ? 29
==========================================================
Hits ? 221
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
jsjoeio
force-pushed
the
jsjoeio-fix-ssr-after
branch
from
aca0aec
to
17b66df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This fixes a bug which assumes that tests don't run in SSR environments.
Why:
With frameworks like Next.js and Remix rendering components on the server, it's important that this library can mimic SSR environments as closely as possible.
How:
First by adding a test that reproduces the issue and then by moving this logic "into the hydrate function so we reference document when they want it to render for real." (suggested by mpeyper).
Checklist: