Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add DialogFlow https webhook server #242

Closed
wants to merge 10 commits into from

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Apr 27, 2021

This PR is for getting https POST responses from DialogFlow webhook. If you use this, you can execute app_manager apps from Google Home, Google Chat, Line, Slack, etc...

ToDo

Document

  • Make README
  • Make DialogFlow Manual
  • Make demo video

Coding

  • Make the correct POST response defined at here

@mqcmd196 mqcmd196 requested a review from knorth55 April 27, 2021 06:52
@mqcmd196 mqcmd196 force-pushed the dialogflow_https_server branch from e1a4ee4 to 1ae060e Compare June 2, 2021 07:29
@mqcmd196 mqcmd196 force-pushed the dialogflow_https_server branch from 1ae060e to 249449f Compare June 2, 2021 07:30
@mqcmd196 mqcmd196 force-pushed the dialogflow_https_server branch from 36951c2 to 2e2df9b Compare June 3, 2021 04:18
@mqcmd196 mqcmd196 marked this pull request as ready for review June 3, 2021 04:19
@mqcmd196 mqcmd196 requested review from 708yamaguchi and k-okada June 3, 2021 04:19
@mqcmd196 mqcmd196 changed the title [WIP]Add DialogFlow https webhook server Add DialogFlow https webhook server Jun 3, 2021
@mqcmd196
Copy link
Member Author

mqcmd196 commented Jun 3, 2021

It's ready for reviewing

@knorth55 knorth55 mentioned this pull request Jun 3, 2021
14 tasks
dialogflow_task_executive/README.md Outdated Show resolved Hide resolved
dialogflow_task_executive/README.md Outdated Show resolved Hide resolved
dialogflow_task_executive/README.md Outdated Show resolved Hide resolved
dialogflow_task_executive/README.md Outdated Show resolved Hide resolved
dialogflow_task_executive/node_scripts/webhook_server.py Outdated Show resolved Hide resolved
dialogflow_task_executive/launch/webhook_server.launch Outdated Show resolved Hide resolved
dialogflow_task_executive/node_scripts/webhook_server.py Outdated Show resolved Hide resolved
dialogflow_task_executive/node_scripts/webhook_server.py Outdated Show resolved Hide resolved
dialogflow_task_executive/.gitignore Outdated Show resolved Hide resolved
dialogflow_task_executive/README.md Outdated Show resolved Hide resolved
@mqcmd196 mqcmd196 requested a review from knorth55 June 3, 2021 07:33
@mqcmd196
Copy link
Member Author

mqcmd196 commented Jun 3, 2021

@knorth55 Thanks, I fixed and confirmed it works in the robot.

@knorth55
Copy link
Member

knorth55 commented Jun 3, 2021

can you check this comment? knorth55/jsk_robot#113 (comment)
@mqcmd196

@knorth55
Copy link
Member

knorth55 commented Jun 4, 2021

Good work! LGTM.
This PR passed all tests!

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for video ;-)

@knorth55 knorth55 mentioned this pull request Aug 24, 2021
7 tasks
@mqcmd196
Copy link
Member Author

I'm sorry for being sooooooo late, I forgot adding the video and I did it.

@mqcmd196 mqcmd196 mentioned this pull request Dec 21, 2021
4 tasks
@mqcmd196
Copy link
Member Author

Please wait for #290 's commit.

@mqcmd196 mqcmd196 changed the title Add DialogFlow https webhook server [WIP] Add DialogFlow https webhook server Dec 28, 2021
@mqcmd196
Copy link
Member Author

close and separate package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants