Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get name from the eus model if the argument name is not passed #169

Merged
merged 4 commits into from
May 14, 2016

Conversation

mmurooka
Copy link
Member

@mmurooka mmurooka commented Jan 8, 2016

eusモデルをurdfに変換するスクリプトを微修正しました.

@mmurooka
Copy link
Member Author

Cloud you review and merge if no problem?

@k-okada
Copy link
Member

k-okada commented May 5, 2016

please rebase origin/master

@k-okada
Copy link
Member

k-okada commented May 5, 2016

I still have doubt on supporting eus->urdf converter because I can not take responsibility for this, so

  1. please add test code for this
  2. please add your name to maintainer

@mmurooka
Copy link
Member Author

mmurooka commented May 5, 2016

I still have doubt on supporting eus->urdf converter because I can not take responsibility for this, so

  1. please add test code for this
  2. please add your name to maintainer

I agree with supporting eus->urdf converter so I will make another PR and do 1) and 2).
But before that, I'd like to double check that these codes are originally added by NOT only my opinion but discussing with some major JSK members. cf. jsk-ros-pkg/jsk_demos#988 (comment)

@mmurooka mmurooka force-pushed the fix-convert-eus branch from 3e35a6b to 0cea7ea Compare May 9, 2016 08:00
@mmurooka
Copy link
Member Author

Travis passed. Commit of test code is merged and test passed. Cloud you merge?

@k-okada k-okada merged commit 877fc00 into jsk-ros-pkg:master May 14, 2016
@mmurooka mmurooka deleted the fix-convert-eus branch May 14, 2016 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants