use pepper.rosinstall for development environment setup #1124
Conversation
|
|
||
| Finally, please compile them. | ||
|
|
||
| ``` | ||
| catkin build --continue-on-failure | ||
| catkin build peppereus |
There was a problem hiding this comment.
I think catkin build naoqi_driver is also required because this package is based on roscpp.
There was a problem hiding this comment.
I think peppereus depends on pepper_bringup and pepper_bringup depends on naoqi_driver. Please double check
There was a problem hiding this comment.
catkin b jsk_pepper_startup seems to be also required.
(catkin b jsk_pepper(nao)_startup and catkin b pepper(nao)eus)
Should I add pepper(nao)eus dependency to jsk_pepper(nao)_startup?
There was a problem hiding this comment.
In addition, I thought .rosinstall file name can be naoqi.rosinstall or something because this environment setup is also for NAO.
There was a problem hiding this comment.
Should I add pepper(nao)eus dependency to jsk_pepper(nao)_startup?
if pepepreus itself depends on jsk_pepper_startup we need this. I'am not sure, but in my understanding, suppose we program pepper with groups, like 少人数ゼミ．Someone need to run jsk_pepper_startup to bringup necessary ROS nodes for pepper, and others who just use peppereus does not need to use `jsk_pepper_startup, just to update the document
catkin b peppereus jsk_pepper_startup
would be ok
naoqi.rosinstall
that's good idea. can you create PR against k-okada:rosinstall?
There was a problem hiding this comment.
I sent a PR (k-okada#3). Could you please check this?
jsk_naoqi_robot/pepper.rosinstall
Outdated
| # wait for 0.5.16 release | ||
| - git: | ||
| local-name: nao_robot | ||
| uri: https://github.com/ros-naoqi/nao_robot |
There was a problem hiding this comment.
In fact, I also use kochigami-develop for nao_robot package.
I'll consider whether we really need kochigami-develop or not.
There was a problem hiding this comment.
jsk_naoqi_robot/pepper.rosinstall
Outdated
| # wait for 0.1.11 | ||
| - git: | ||
| local-name: pepper_robot | ||
| uri: https://github.com/ros-naoqi/pepper_robot |
There was a problem hiding this comment.
In fact, I also use kochigami-develop for pepper_robot package.
I'll consider whether we really need kochigami-develop or not.
There was a problem hiding this comment.
The difference is ros-naoqi/pepper_robot@master...kochigami:kochigami-develop
+ <arg name="boot_config_file_name" value="$(arg boot_config_file_name)" />
And this is default behavior of naoqi_driver.launch
https://github.com/kochigami/naoqi_driver/blob/kochigami-develop/launch/naoqi_driver.launch
|
Thank you very much for updating README and |
jsk_naoqi_robot/pepper.rosinstall
Outdated
| uri: https://github.com/kochigami/naoqi_bridge | ||
| version: kochigami-develop | ||
| # add fade leds srv (https://github.com/ros-naoqi/naoqi_bridge_msgs/pull/41) | ||
| # [ALChestButton] add msg for ChestButtonPressed (https://github.com/ros-naoqi/naoqi_bridge_msgs/pull/40) |
There was a problem hiding this comment.
below "[ALChestButton] ..." this should be added:
# add many msgs and srvs
[jsk_naoqi_robot/pepper.rosinstall] modify .rosinstall file name
wstool merge pepper.rosinstall to create development environment including kochigami-devel