Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wait for upstream] [jsk_fetch_startup] add basic authentication in roswww on fetch #1232

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

knorth55
Copy link
Member

wait for upstream
depend on tork-a/roswww#51

add basic authentication for all roswww pages

roswww_basic_auth

cc. @708yamaguchi

@708yamaguchi
Copy link
Member

708yamaguchi commented Jul 15, 2020

I accessed this page with chrome, but at first topic list was not displayed.
It behaves correctly after two reloads. (I don't know the reason, but 2 reload seems important)

rwt_error

I tested this page with two computer.

  1. Chrome browser on Ubuntu 18.04.
    When I use normal window, this only happens once.
    When I create new incognito window, this happens repeatedly.

  2. Chrome browser on iPhone X.
    Topic list is never displayed. From what I remember, it was displayed at the previous version.

@knorth55
Copy link
Member Author

knorth55 commented Jul 15, 2020

@708yamaguchi I confirmed the issue, but I can get proper page at once when I connect to pr1040.
I checked with web developer and some css are failed to be downloaded.
maybe something got timeout.

@708yamaguchi
Copy link
Member

Thank you for thoughts. I agree with you.
It seems that not only css files but also ROSLIB or jQuery are sometimes not loaded.

The error says,

 Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH roslib.js:1

This may be cache problem (?)
https://cpoint-lab.co.jp/article/201809/5517/

@knorth55 knorth55 added this to the 1.1.1 milestone Oct 21, 2020
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knorth55
Copy link
Member Author

yes we need tork-a/roswww#51.
@k-okada do you have a plan to merge tork-a/roswww#51 ?

@k-okada k-okada merged commit 8341158 into jsk-ros-pkg:master Jul 16, 2021
@knorth55 knorth55 deleted the fetch-basic-auth branch July 16, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants