Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add panda robot #1343

Closed
wants to merge 47 commits into from

Conversation

ykawamura96
Copy link
Contributor

@ykawamura96 ykawamura96 commented Jun 8, 2021

This PR is on top of previous PR: #1326 to include teleop_package (jsk_panda_teleop)

TODO:

  • add README.md to describe usage
  • add .rosinstall

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added wrong file?

A jsk_panda_robot/jsk_panda_accessories/tool_mounter/~$link_7.SLDPRT (0)

@ykawamura96
Copy link
Contributor Author

added wrong file?

A jsk_panda_robot/jsk_panda_accessories/tool_mounter/~$link_7.SLDPRT (0)

I removed the file. Thank you for the review.

@ykawamura96 ykawamura96 added the panda dual franka robot in JSK label Jun 10, 2021
k-okada and others added 16 commits June 18, 2021 19:40
add allow-other-keys to dual_panda-robot-interface :init
Remove rwt teleop in default launch file and fix typos
[jsk_panda_robot] panda_start_launch now runs hand-eye usb camera by …
uri: https://github.com/ykawamura96/jsk_robot.git
version: add_panda_robot

# Needed for using haptics devices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #1543 and #1544

@@ -0,0 +1,35 @@
#!/usr/bin/env roseus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this node?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in #1543 and #1544

<!-- uvc_cam -->
<!-- TODO: Use udev rule -->
<arg name="right_camera_dev" default="/dev/video0" />
<arg name="left_camera_dev" default="/dev/video2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be /dev/video1 for defaults?

<arg if = "$(arg quiet)" name="other_options" value="-q"/>
<arg name="other_topics" value="$(arg other_topics)
/audio
/camera/depth/camera_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixing tab / spaces

@@ -0,0 +1,19 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need this. for learning program?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in #1543 and #1544

- rarm_joint5
- rarm_joint6
- rarm_joint7

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more blank line?

(send *ri* :stop-grasp :rarm))

(main)
(eixt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

@@ -0,0 +1,24 @@

function init_ros_ip () {
export ROS_MASTER_URI=http://133.11.216.227:11311
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should write our IP settings on README.md and information on where should we fix, if we change IP address of devices.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting IP address manually is removed in #1543 and #1544

(action (case arm
(:rarm r-gripper-action)
(:larm l-gripper-action)))
(joint-names (case arm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent?

@pazeshun pazeshun mentioned this pull request Jul 22, 2022
@k-okada
Copy link
Member

k-okada commented Jul 22, 2022

closed via #1543 and #1544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need fix panda dual franka robot in JSK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants