-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add panda robot #1343
[WIP] Add panda robot #1343
Conversation
add panda accessories CAD files for tool mounter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added wrong file?
A jsk_panda_robot/jsk_panda_accessories/tool_mounter/~$link_7.SLDPRT (0)
I removed the file. Thank you for the review. |
add allow-other-keys to dual_panda-robot-interface :init
…s_publisher 'in dual_panda.launch
…robot into add_panda_robot
…d now use *ri* to get joint-states
… in dual_panda.launch
Add end-coords_publisher.l
Remove rwt teleop in default launch file and fix typos
[jsk_panda_robot] panda_start_launch now runs hand-eye usb camera by …
jsk_panda_robot/jsk_panda.rosinstall
Outdated
uri: https://github.com/ykawamura96/jsk_robot.git | ||
version: add_panda_robot | ||
|
||
# Needed for using haptics devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add what is the difference between https://github.com/ykawamura96/Geomagic_Touch_ROS_Drivers and https://github.com/bharatm11/Geomagic_Touch_ROS_Drivers, and list of PRs that should be merged to use https://github.com/bharatm11/Geomagic_Touch_ROS_Drivers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,35 @@ | |||
#!/usr/bin/env roseus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- uvc_cam --> | ||
<!-- TODO: Use udev rule --> | ||
<arg name="right_camera_dev" default="/dev/video0" /> | ||
<arg name="left_camera_dev" default="/dev/video2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be /dev/video1
for defaults?
<arg if = "$(arg quiet)" name="other_options" value="-q"/> | ||
<arg name="other_topics" value="$(arg other_topics) | ||
/audio | ||
/camera/depth/camera_info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixing tab / spaces
@@ -0,0 +1,19 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need this. for learning program?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- rarm_joint5 | ||
- rarm_joint6 | ||
- rarm_joint7 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add one more blank line?
(send *ri* :stop-grasp :rarm)) | ||
|
||
(main) | ||
(eixt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
@@ -0,0 +1,24 @@ | |||
|
|||
function init_ros_ip () { | |||
export ROS_MASTER_URI=http://133.11.216.227:11311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should write our IP settings on README.md and information on where should we fix, if we change IP address of devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(action (case arm | ||
(:rarm r-gripper-action) | ||
(:larm l-gripper-action))) | ||
(joint-names (case arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indent?
This PR is on top of previous PR: #1326 to include teleop_package (jsk_panda_teleop)
TODO: