Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_pr2_lifelog] add time related options for rosbag_play #1894

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[jsk_pr2_lifelog] add time related options for rosbag_play #1894

merged 1 commit into from
Dec 11, 2023

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Dec 4, 2023

Adding start_time, duration_time options for rosbag play like fetch1075

@github-actions github-actions bot added the PR2 label Dec 4, 2023
nakane11
nakane11 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nakane11 nakane11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it works on my laptop.

tkmtnt7000
tkmtnt7000 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@tkmtnt7000 tkmtnt7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR

@k-okada k-okada merged commit 7317e91 into jsk-ros-pkg:master Dec 11, 2023
8 checks passed
@mqcmd196 mqcmd196 deleted the PR/pr2-rosbag-play-option branch December 11, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazeshun pazeshun pazeshun left review comments

@nakane11 nakane11 nakane11 approved these changes

@tkmtnt7000 tkmtnt7000 tkmtnt7000 approved these changes

Assignees
No one assigned
Labels
PR2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mqcmd196 @pazeshun @nakane11 @tkmtnt7000 @k-okada