Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should warn "PoseArray rviz plugin is deprecated in Kinetic, Melodic and Noetic" #785

Closed
knorth55 opened this issue Oct 24, 2020 · 1 comment · Fixed by #786
Closed
Labels

Comments

@knorth55
Copy link
Member

knorth55 commented Oct 24, 2020

PoseArray rviz plugin is added in jsk_visualization for indigo and hyrdo devel because of upstream late response.
#349

However, the situation got changed, and we can use pose array default plugin in Kinetic, Melodic and Noetic...
Maybe we should warn that JSK version is deprecated, and switch to use rviz default plugin.

PR to rviz for hydro (closed)
ros-visualization/rviz#858

PR to rviz for kinetic
ros-visualization/rviz#1022

cc. @pazeshun

@knorth55 knorth55 added the bug label Oct 24, 2020
@pazeshun
Copy link
Contributor

Currently, rviz dies when we load PoseArray in jsk_rviz_plugins subscribing messages whose elements are all zero.
You can check it by:

rosbag play poses_causing_rviz_death.bag --clock --loop
rviz -d poses_causing_rviz_death.rviz

poses_causing_rviz_death.bag: https://drive.google.com/file/d/1td4nojPODCbxojYSeR7w19T3aRxSg389/view?usp=sharing
poses_causing_rviz_death.rviz: https://gist.github.com/pazeshun/beeb9415db2611561644f5f1f6400d82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants