Included share-networks to collected stats #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskarpe
requested changes
Dec 26, 2018
There was a problem hiding this comment.
Thank you for the PR!
Your first commit is excellent, however - I don't agree with the other two. I understand the desire to keep the binary out of the repository, however it adds complexity to the installation. This complexity isn't covered in the readme at all now.
If the first commit was in a merge request by itself, I'd very much like to merge it
|
I removed the other commits. I installed the dhcpd-pools package with the following command in Ubuntu: sudo apt install dhcpd-pools (Included in the universe repository) Because of that I removed it from the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included shared-networks to collected stats, helps a lot with shared-network with different subnets or ranges.