Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

pivotal-tracker can run in jruby #62

Closed
wants to merge 2 commits into from
Closed

Conversation

joelash
Copy link
Contributor

@joelash joelash commented Sep 27, 2012

Replaced happymapper with nokogiri-happymapper and made some necessary changes around support that. All tests pass in jruby-1.6.7, jruby-1.7.0.preview2 and ruby-1.9.1+

@joelash
Copy link
Contributor Author

joelash commented Oct 5, 2012

Hey, was wondering what your thoughts about merging this were? It'd be beneficial to me at work if I could use a version of pivotal-tracker that runs independent of ruby platform. Thanks.

@jasonnoble
Copy link
Collaborator

@joelash, I cherry picked 76d9c87 and rebuilt the gemspec via our automated tools. Your changes have been pushed as version 0.5.7. Thanks for the contribution, let us know if you see any issues.

@jasonnoble jasonnoble closed this Oct 28, 2012
@jasonnoble
Copy link
Collaborator

I had to revert this commit because 0.5.7 didn't load properly under MRI. Release 0.5.8.

@jasonnoble jasonnoble reopened this Oct 28, 2012
@D3xx73r
Copy link

D3xx73r commented Jan 11, 2013

Hi,

I was reviewing the gemspec and I found that there is still a runtime dependency for Nokogiri 1.4 and I was wondering: - is this dependency needed?

I want to use this gem under JRuby but it keeps trying to install libxml-ruby, I will try to fin a way to deal with this and come back with a pull request.

Cheers!

@jsmestad
Copy link
Owner

We should not be bound to any particular version of nokogiri. Please test the removal and verify everything still functions properly and we can pull that in.

@pivotal-casebook
Copy link

Can this be merged in if it is still passing? Happymapper dependency is limiting us from using the gem on JRuby.

@jsmestad
Copy link
Owner

@pivotal-casebook can you pull and merge in the lastest master? I can pull in the change.

@jsmestad jsmestad closed this Mar 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants