small improvements #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmnbom
requested changes
Mar 19, 2019
| @@ -226,6 +226,7 @@ def inline_add_repo(update, context): | |||
| results = [] | |||
| if access_token: | |||
| filtered_repositories = [] | |||
| registered_repos = context.chat_data.setdefault('repos', {}) | |||
There was a problem hiding this comment.
Inline callbacks have no chat_data as they don't receive the chat.
This leads me to believe that this might be quite difficult to implement.
| @@ -180,7 +180,7 @@ def __init__(self, key, value, text=None, states=None, default=None): | |||
| if (text is None and states is None) or (text is not None and states is not None): | |||
| raise RuntimeError | |||
| if text is not None: | |||
| states = ((False, text), (True, '\u2714' + text)) | |||
| states = ((False, text), (True, '☑️' + text)) | |||
jsmnbom
reviewed
Mar 19, 2019
| pip-selfcheck.json | ||
|
|
||
| .vscode |
There was a problem hiding this comment.
Please don't add IDE specific stuff to gitignore files. It's a much better idea to use the global gitignore on your system :)
|
Thanks a lot for taking the time to do this. I've left some review comments :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please test, cause I don't have a proper setup yet