Update to latest version of EphemeralMongo #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkoelman
force-pushed
the
update-mongo-dependencies
branch
from
10ad498 to
bdb2d32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 13 13
Lines 241 241
Branches 36 36
=======================================
Hits 229 229
Misses 7 7
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
EphemeralMongo is compatible with MongoDB.Driver 3.x now. See https://github.com/asimmon/ephemeral-mongo/releases/tag/3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental. This PR updates to the latest version of EphemeralMongo, which is a fork of Mongo2Go.
This version doesn't work with the newer 3.x version of MongoDB.Driver. We switched to it in #23 for reasons I don't remember. Mongo2Go is still alive and does support the latest version, so perhaps we should switch back?
Whether we use EphemeralMongo or Mongo2Go, we'll need to take a breaking change by bumping the MongoDB.Driver version that JsonApiDotNetCore takes a dependency on.
QUALITY CHECKLIST