Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty fields #1009

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Fix empty fields #1009

merged 2 commits into from
Jun 11, 2021

Conversation

bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Jun 9, 2021

Allows incoming empty fieldset (json:api spec compliance). The code adds a default interface property to not break existing implementations. Includes a workaround for bug dotnet/aspnetcore#33394.

Fixes #996.

…dds a default interface property to not break existing implementations.
@bart-degreed bart-degreed requested a review from maurei June 9, 2021 08:23
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1009 (afb02c0) into master (56c3416) will decrease coverage by 0.13%.
The diff coverage is 77.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   92.01%   91.87%   -0.14%     
==========================================
  Files         283      286       +3     
  Lines        7661     7718      +57     
==========================================
+ Hits         7049     7091      +42     
- Misses        612      627      +15     
Impacted Files Coverage Δ
.../JsonApiDotNetCore/Middleware/FixedQueryFeature.cs 59.09% <59.09%> (ø)
.../JsonApiDotNetCore/Middleware/FixedQueryHelpers.cs 80.00% <80.00%> (ø)
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 100.00% <100.00%> (ø)
...e/Queries/Internal/Parsing/SparseFieldSetParser.cs 100.00% <100.00%> (ø)
...etCore/QueryStrings/IQueryStringParameterReader.cs 100.00% <100.00%> (ø)
...NetCore/QueryStrings/Internal/QueryStringReader.cs 100.00% <100.00%> (ø)
...ternal/SparseFieldSetQueryStringParameterReader.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c3416...afb02c0. Read the comment docs.

@maurei maurei merged commit f145564 into master Jun 11, 2021
@maurei maurei deleted the fix-empty-fields branch June 11, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Sending an empty fields parameter results in error
2 participants