Skip to content

Move resource annotations into separate package #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2021
Merged

Conversation

bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Dec 8, 2021

This enables to reference just JsonApiDotNetCore.Annotations, instead of the full package, in solutions where the models are in a shared project, separate from the API project.

As it turns out, NotMappedAttribute is defined in assembly System.ComponentModel.Annotations, so it is unrelated to EF Core, therefore we can keep it.

Closes #730.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • Adapted tests
  • Documentation updated
  • N/A: Created issue to update Templates: {ISSUE_NUMBER}

@bart-degreed bart-degreed marked this pull request as draft December 8, 2021 17:56
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1127 (2253f83) into master (9c9a4f2) will increase coverage by 0.04%.
The diff coverage is 84.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   89.41%   89.45%   +0.04%     
==========================================
  Files         245      242       -3     
  Lines        7294     7209      -85     
==========================================
- Hits         6522     6449      -73     
+ Misses        772      760      -12     
Impacted Files Coverage Δ
...NetCoreExample/Controllers/NonJsonApiController.cs 0.00% <0.00%> (ø)
...NetCoreExample/Controllers/OperationsController.cs 0.00% <0.00%> (ø)
...ples/JsonApiDotNetCoreExample/Data/AppDbContext.cs 0.00% <0.00%> (ø)
...otNetCoreExample/Definitions/TodoItemDefinition.cs 0.00% <0.00%> (ø)
...Examples/JsonApiDotNetCoreExample/Models/Person.cs 0.00% <0.00%> (ø)
...rc/Examples/JsonApiDotNetCoreExample/Models/Tag.cs 0.00% <0.00%> (ø)
...amples/JsonApiDotNetCoreExample/Models/TodoItem.cs 0.00% <0.00%> (ø)
src/Examples/JsonApiDotNetCoreExample/Program.cs 0.00% <0.00%> (ø)
...Core/AtomicOperations/MissingTransactionFactory.cs 0.00% <0.00%> (ø)
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% <0.00%> (ø)
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2abccb...2253f83. Read the comment docs.

@bart-degreed bart-degreed marked this pull request as ready for review December 8, 2021 23:15
@bart-degreed bart-degreed requested a review from maurei December 8, 2021 23:23
@maurei maurei merged commit b442519 into master Dec 9, 2021
@maurei maurei deleted the annotations-package branch December 9, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Extract IIdentifiable and annotation attributes (Attr, HasOne, etc.) into separate package
2 participants