Tests that reveal issues with resources that rely on heritance, updated

Build.ps1

@@ -94,6 +94,15 @@ function CreateNuGetPackage {
     CheckLastExitCode
 }
 
+# In a PR the base branch needs to be fetched in order for regitlint to work.
+function FetchBaseBranchIfNotMaster() {
+    if ($env:APPVEYOR_PULL_REQUEST_NUMBER -And $env:APPVEYOR_REPO_BRANCH -ne "master") {
+        git fetch -q origin ${env:APPVEYOR_REPO_BRANCH}:${env:APPVEYOR_REPO_BRANCH}
+    }
+}
+
+FetchBaseBranchIfNotMaster
+
 dotnet tool restore
 CheckLastExitCode
 

appveyor.yml

@@ -15,6 +15,7 @@ environment:
 branches:
   only:
   - master
+  - resource-inheritance
   - develop
   - unstable
   - /release\/.+/

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Animal.cs

@@ -0,0 +1,16 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public abstract class Animal : Identifiable<long>
+{
+    [Attr]
+    public bool Feline { get; set; }
+
+    [Attr]
+    public bool IsDomesticated { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Book.cs

@@ -0,0 +1,12 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public sealed class Book : Content
+{
+    [Attr]
+    public int PageCount { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Cat.cs

@@ -0,0 +1,17 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+public sealed class Cat : Animal
+{
+    [Attr]
+    public bool ScaredOfDogs { get; set; }
+
+    public Cat()
+    {
+        Feline = true;
+    }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Content.cs

@@ -0,0 +1,13 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public abstract class Content : Identifiable<long>
+{
+    [HasMany]
+    public List<Person> Author { get; set; } = new();
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Dog.cs

@@ -0,0 +1,12 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public sealed class Dog : Animal
+{
+    [Attr]
+    public bool RespondsToName { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Female.cs

@@ -0,0 +1,12 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public sealed class Female : Person
+{
+    [Attr]
+    public bool IsPregnant { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Male.cs

@@ -0,0 +1,12 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public sealed class Male : Person
+{
+    [Attr]
+    public bool HasBeard { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Person.cs

@@ -0,0 +1,22 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public abstract class Person : Identifiable<long>
+{
+    [Attr]
+    public bool Retired { get; set; }
+
+    [HasOne]
+    public Animal? Pet { get; set; }
+
+    [HasMany]
+    public List<Person> Parents { get; set; } = new();
+
+    [HasMany]
+    public List<Content> FavoriteContent { get; set; } = new();
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/Models/Video.cs

@@ -0,0 +1,12 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCore.Resources.Annotations;
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+[Resource(ControllerNamespace = "JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance")]
+public sealed class Video : Content
+{
+    [Attr]
+    public int Duration { get; set; }
+}

test/JsonApiDotNetCoreTests/IntegrationTests/LegacyResourceInheritance/ResourceInheritanceDbContext.cs

@@ -0,0 +1,45 @@
+using JetBrains.Annotations;
+using JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance.Models;
+using Microsoft.EntityFrameworkCore;
+
+// @formatter:wrap_chained_method_calls chop_always
+
+namespace JsonApiDotNetCoreTests.IntegrationTests.LegacyResourceInheritance;
+
+[UsedImplicitly(ImplicitUseTargetFlags.Members)]
+public sealed class ResourceInheritanceDbContext : DbContext
+{
+    public DbSet<Person> People => Set<Person>();
+    public DbSet<Cat> Cats => Set<Cat>();
+    public DbSet<Dog> Dogs => Set<Dog>();
+    public DbSet<Female> Females => Set<Female>();
+    public DbSet<Male> Males => Set<Male>();
+    public DbSet<Book> FictionBooks => Set<Book>();
+    public DbSet<Video> NonFictionBooks => Set<Video>();
+
+    public ResourceInheritanceDbContext(DbContextOptions<ResourceInheritanceDbContext> options)
+        : base(options)
+    {
+    }
+
+    protected override void OnModelCreating(ModelBuilder modelBuilder)
+    {
+        modelBuilder.Entity<Person>()
+            .ToTable("Persons")
+            .HasDiscriminator<int>("Type")
+            .HasValue<Male>(1)
+            .HasValue<Female>(2);
+
+        modelBuilder.Entity<Animal>()
+            .ToTable("Animals")
+            .HasDiscriminator<int>("Type")
+            .HasValue<Cat>(1)
+            .HasValue<Dog>(2);
+
+        modelBuilder.Entity<Content>()
+            .ToTable("Books")
+            .HasDiscriminator<int>("Type")
+            .HasValue<Video>(1)
+            .HasValue<Book>(2);
+    }
+}