-
-
Notifications
You must be signed in to change notification settings - Fork 158
Minor serialization tweaks #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5ec214
to
b48755f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
- Coverage 92.58% 92.57% -0.01%
==========================================
Files 241 242 +1
Lines 7700 7694 -6
==========================================
- Hits 7129 7123 -6
Misses 571 571
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f3bb2b0
to
2f23373
Compare
…der (added in .NET 6). Also makes the model a bit more correct, as "ref" elements (used in atomic:operations) cannot occur in "data".
2f23373
to
e5276b5
Compare
e5276b5
to
f760e8f
Compare
maurei
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal of this PR was to activate the System.Text.Json source generator. It is documented to improve performance and use less memory.
After making the change, I wasn't able to see improvements in benchmarks. Narrowing down the benchmark resulted in a performance gain of 2 microseconds and 838 bytes per request. Given all the trouble we've had in the past with source generators (bugs in the .NET SDK, increased build times, Resharper poorly supporting their use), I don't think it's worth making the change, so I reverted that commit. It's still in the PR commit history, for future reference.
This PR is still useful to merge because it also contains:
[JsonPropertyOrder]
, which enabled to simplify the JSON:API object model a bitQUALITY CHECKLIST