Skip to content

Improve error message when duplicate controllers found #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

bkoelman
Copy link
Member

Improve error message when duplicate controllers are found, to include the fully qualified type names of the conflicting controllers. This makes it easier for JADNC consumers to root-cause the conflict.

Closes #1188.

QUALITY CHECKLIST

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1193 (3996cc4) into master (79d918a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3996cc4 differs from pull request most recent head 1dc249b. Consider uploading reports for the commit 1dc249b to get more accurate results

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         242      242           
  Lines        7706     7707    +1     
=======================================
+ Hits         7135     7136    +1     
  Misses        571      571           
Impacted Files Coverage Δ
...iDotNetCore/Middleware/JsonApiRoutingConvention.cs 92.06% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman marked this pull request as ready for review October 1, 2022 18:04
@bkoelman bkoelman requested a review from maurei October 1, 2022 18:04
…e the fully qualified type names of the conflicting controllers
@bkoelman bkoelman force-pushed the duplicate-controllers-error branch from 3aa3af7 to 1dc249b Compare October 2, 2022 15:46
@maurei maurei merged commit da9048f into master Oct 19, 2022
@maurei maurei deleted the duplicate-controllers-error branch October 19, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when duplicate controller found
2 participants