Skip to content

Fix namespace imports in controller source generator #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2023
Merged

Fix namespace imports in controller source generator #1261

merged 3 commits into from
Mar 11, 2023

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 5, 2023 •
edited
Loading

Fixes #1260.

image

QUALITY CHECKLIST

@codecov
Copy link

codecov bot commented Mar 5, 2023 •
edited
Loading

Codecov Report

Merging #1261 (2792a2b) into master (8a5e914) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2792a2b differs from pull request most recent head b2e5bb6. Consider uploading reports for the commit b2e5bb6 to get more accurate results

@@           Coverage Diff           @@
##           master    #1261   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         243      243           
  Lines        7813     7813           
=======================================
  Hits         7242     7242           
  Misses        571      571
Impacted Files Coverage Δ
...ApiDotNetCore.SourceGenerators/SourceCodeWriter.cs 97.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman changed the base branch from master to query-tweaks March 5, 2023 14:19
@bkoelman bkoelman marked this pull request as ready for review March 5, 2023 14:19
@bkoelman bkoelman requested a review from maurei March 5, 2023 14:20
Base automatically changed from query-tweaks to master March 11, 2023 10:23
@maurei maurei merged commit 0d914d8 into master Mar 11, 2023
@maurei maurei deleted the fix-namespace-imports-gen branch March 11, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurei maurei maurei approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source generator produces unused using when controller and resource are in same namespace
2 participants
@bkoelman @maurei