Skip to content

Improve serializer performance #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Improve serializer performance #1265

merged 1 commit into from
Apr 12, 2023

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Apr 7, 2023

Improve performance of response serialization for large number of included resources.

QUALITY CHECKLIST

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #1265 (feb040f) into master (d2e321c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head feb040f differs from pull request most recent head 5dd256f. Consider uploading reports for the commit 5dd256f to get more accurate results

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   92.69%   92.67%   -0.02%     
==========================================
  Files         243      243              
  Lines        7813     7814       +1     
==========================================
  Hits         7242     7242              
- Misses        571      572       +1     
Impacted Files Coverage Δ
...e/Serialization/Response/ResourceObjectTreeNode.cs 82.65% <100.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman marked this pull request as ready for review April 7, 2023 17:41
@bkoelman
Copy link
Member Author

@maurei this was requested by Erik, I'm awaiting feedback if this solves his problem.

@ebryn
Copy link

ebryn commented Apr 12, 2023

@bkoelman This makes a huge difference! We can now fetch 250k rows in 24 seconds. It took an hour previously. Thanks!

@bkoelman bkoelman merged commit 9a2f364 into master Apr 12, 2023
@bkoelman bkoelman deleted the serializer-perf branch April 12, 2023 22:06
@ebryn
Copy link

ebryn commented Apr 13, 2023

@bkoelman Would it be possible to have a release with this change published?

@bkoelman
Copy link
Member Author

Yes, I was already preparing for that. There's a few more things I'd like to get in, probably somewhere next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants