Skip to content

Replace CreateTupleAccessExpressionForConstant with simpler implementation #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

bkoelman
Copy link
Member

This PR replaces the internal method CreateTupleAccessExpressionForConstant with CloseOver, which is simpler and requires less reflection.

Based on the conversation at dotnet/efcore#28151 (comment).

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (587d972) 90.74% compared to head (3f62b77) 90.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   90.74%   90.74%   -0.01%     
==========================================
  Files         344      344              
  Lines       11003    11002       -1     
  Branches     1813     1811       -2     
==========================================
- Hits         9985     9984       -1     
  Misses        669      669              
  Partials      349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review February 18, 2024 13:31
@bkoelman bkoelman merged commit be6decc into master Feb 18, 2024
@bkoelman bkoelman deleted the simplify-parametrized-constants-in-sql branch February 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant