Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter operations based on GenerateControllerEndpoints usage #1561

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

bkoelman
Copy link
Member

This PR adds IAtomicOperationFilter, which is used to constrain the exposed atomic:operations. The default implementation filters based on the usage of GenerateControllerEndpoints (which defaults to All, in which case all operations are exposed).

See the related issue for notes on this breaking change.

Fixes #1560.

QUALITY CHECKLIST

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (461d6d3) to head (e47faf3).

Files Patch % Lines
...NetCore/AtomicOperations/DefaultOperationFilter.cs 75.00% 1 Missing and 2 partials ⚠️
...NetCore/AtomicOperations/IAtomicOperationFilter.cs 0.00% 2 Missing ⚠️
...ore/Controllers/BaseJsonApiOperationsController.cs 95.55% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   90.84%   90.83%   -0.02%     
==========================================
  Files         346      348       +2     
  Lines       11097    11158      +61     
  Branches     1821     1828       +7     
==========================================
+ Hits        10081    10135      +54     
- Misses        669      673       +4     
- Partials      347      350       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review June 18, 2024 09:20
@bkoelman bkoelman merged commit 4e0f2a7 into master Jun 18, 2024
16 checks passed
@bkoelman bkoelman deleted the constrained-operations branch June 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Constrain available operations
1 participant