Fix: crash when deserializing post with relationship to abstract base class #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurei
suggested changes
Sep 17, 2020
| @@ -168,15 +168,19 @@ private IIdentifiable ParseResourceObject(ResourceObject data) | |||
| var rio = (ResourceIdentifierObject)relationshipData.Data; | |||
| var relatedId = rio?.Id; | |||
|
|
|||
| var resourceContext = relationshipData.SingleData == null | |||
There was a problem hiding this comment.
I think this can be simplified?
var relatedResourceType = relationshipData.SingleData == null
? attr.RightType
: ResourceContextProvider.GetResourceContext(relationshipData.SingleData.Type).ResourceType;
// this does not make sense in the following case: if we're setting the dependent of a one-to-one relationship, IdentifiablePropertyName should be null.
var foreignKeyProperty = resourceProperties.FirstOrDefault(p => p.Name == attr.IdentifiablePropertyName);
if (foreignKeyProperty != null)
// there is a FK from the current resource pointing to the related object,
// i.e. we're populating the relationship from the dependent side.
SetForeignKey(resource, foreignKeyProperty, attr, relatedId, relatedResourceType);
SetNavigation(resource, attr, relatedId, relatedResourceType);There was a problem hiding this comment.
Also: isn't ResourceContextProvider.GetResourceContext(relationshipData.SingleData.Type).ResourceType; always just equal to relationshipData.SingleData.Type? Because relationshipData.SingleData.Type is parsed from the request body, so if I'm not mistaken this will never equal the abstract base type.
| @@ -232,6 +237,7 @@ private void SetNavigation(IIdentifiable resource, HasOneAttribute attr, string | |||
| { // if the relationship is set to null, no need to set the navigation property to null: this is the default value. | |||
| var relatedResources = relationshipData.ManyData.Select(rio => | |||
| { | |||
| // TODO: [#696] Potential location where we crash if the relationship targets an abstract base class. | |||
There was a problem hiding this comment.
I think this is valid. I think we'll have to introduce the equivalent approach as for SetHasOneRelationship
| @@ -87,6 +87,7 @@ protected override void AfterProcessField(IIdentifiable resource, ResourceFieldA | |||
| /// </summary> | |||
| private IIdentifiable ParseIncludedRelationship(RelationshipAttribute relationshipAttr, ResourceIdentifierObject relatedResourceIdentifier) | |||
| { | |||
| // TODO: [#696] Potential location where we crash if the relationship targets an abstract base class. | |||
| @@ -114,6 +114,7 @@ private async Task UpdateManyToManyAsync(IIdentifiable parent, HasManyThroughAtt | |||
|
|
|||
| var newLinks = relationshipIds.Select(x => | |||
| { | |||
| // TODO: [#696] Potential location where we crash if the relationship targets an abstract base class. | |||
There was a problem hiding this comment.
Interesting. This one seems a bit more difficult to resolve
| @@ -137,6 +137,7 @@ public override void SetValue(object resource, object newValue, IResourceFactory | |||
| List<object> throughResources = new List<object>(); | |||
| foreach (IIdentifiable identifiable in (IEnumerable)newValue) | |||
| { | |||
| // TODO: [#696] Potential location where we crash if the relationship targets an abstract base class. | |||
|
Superceded by #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is a good solution, but at least this removes the crash when trying to create an instance of abstract base class (see #696). There are likely more places we need to change.