Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages from partial reads on anonymous structs should not contain the struct definition #421

Closed
disq opened this issue Nov 22, 2019 · 0 comments
Closed

Error messages from partial reads on anonymous structs should not contain the struct definition #421

disq opened this issue Nov 22, 2019 · 0 comments

Comments

@disq
Copy link

disq commented Nov 22, 2019

If a read partially fails and you're decoding in an anonymous (defined in the function or inline, not package level) struct, the error message will actually contain the whole definition, which may be very big, causing very long error messages.

https://play.golang.org/p/eu-dJWFZXom
AllenX2018 added a commit that referenced this issue Mar 30, 2020
@AllenX2018
Merge pull request #433 from AllenX2018/fix-anonymous-struct-error-me…
1f7ee05 
…ssage

fix issue #421
@disq disq closed this as completed Mar 1, 2021
zhenzou pushed a commit to zhenzou/jsoniter that referenced this issue Feb 2, 2022
@AllenX2018
fix issue json-iterator#421
5e540d9
zhenzou pushed a commit to zhenzou/jsoniter that referenced this issue Feb 2, 2022
@AllenX2018
Merge pull request json-iterator#433 from AllenX2018/fix-anonymous-st…
d3693bd 
…ruct-error-message

fix issue json-iterator#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@disq