Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix any str ToInt64 ToUint64 panic #450

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

fantastao
Copy link

Change-Id: Ic1690713d96940258811cdc149b1604128aa91a2

Change-Id: Ic1690713d96940258811cdc149b1604128aa91a2
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #450 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          41       41           
  Lines        5106     5106           
=======================================
  Hits         4405     4405           
  Misses        565      565           
  Partials      136      136           
Impacted Files Coverage Δ
any_str.go 96.59% <100.00%> (ø)
reflect_struct_decoder.go 80.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aeb59...bede7b9. Read the comment docs.

@fantastao
Copy link
Author

fantastao commented Mar 26, 2020

When any.val equals "+" or "-", stringAny.ToInt64 and stringAny.ToUint64 will panic for slice bounds out of range.This commit fixed it.

@AllenX2018 AllenX2018 merged commit b22f393 into json-iterator:master Mar 26, 2020
@AllenX2018
Copy link
Collaborator

Merged. Thanks!

zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants