Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[348] Add reference-to-unknown-keyword tests to earlier drafts #349

Closed
wants to merge 1 commit into from

Conversation

ssilverman
Copy link
Member

Also renaming "reference of" to "reference to".

Closes #348

@ssilverman ssilverman requested a review from a team April 25, 2020 15:52
@Julian
Copy link
Member

Julian commented Apr 25, 2020

Left a comment on #348 (comment) that's relevant.

@ssilverman
Copy link
Member Author

Turns out I don't fully understand this yet. I found this: json-schema-org/json-schema-spec#713, the bug it's fixing (json-schema-org/json-schema-spec#687), and other things that refer to it.

Also renaming "reference of" to "reference to".
Copy link
Member

@Julian Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@ssilverman
Copy link
Member Author

ssilverman commented Apr 29, 2020

@Julian Are you sure this is correct, despite your comments and my response? (#348 (comment))

@Julian
Copy link
Member

Julian commented May 4, 2020

Sounds like #361 will resolve this one, so I think we can move the discussion there.

@Julian Julian closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for reference-to-unknown to earlier drafts
2 participants