Skip to content

Add test cases for other valid label separators in IDN hostnames #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
+189 −4
Merged

Add test cases for other valid label separators in IDN hostnames #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad94cac
Add test cases for other valid label separators in IDN hostnames
Feb 3, 2025
ce9f68c
Add link to rfc and quote
Feb 5, 2025
4fa572d
Move tests for rfc3490#3.1 into a separate test case
Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion tests/draft-next/optional/format/idn-hostname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,58 @@
"description": "empty string",
"data": "",
"valid": false
},
}
]
},
{
"description": "validation of separators in internationalized host names",
"specification": [
{"rfc3490": "3.1", "quote": "Whenever dots are used as label separators, the following characters MUST be recognized as dots: U+002E (full stop), U+3002 (ideographic full stop), U+FF0E (fullwidth full stop), U+FF61(halfwidth ideographic full stop)"}
],
"schema": {
"$schema": "https://json-schema.org/draft/next/schema",
"format": "idn-hostname"
},
"tests": [
{
"description": "single dot",
"data": ".",
"valid": false
},
{
"description": "single ideographic full stop",
"data": "\u3002",
"valid": false
},
{
"description": "single fullwidth full stop",
"data": "\uff0e",
"valid": false
},
{
"description": "single halfwidth ideographic full stop",
"data": "\uff61",
"valid": false
},
{
"description": "dot as label separator",
"data": "a.b",
"valid": true
},
{
"description": "ideographic full stop as label separator",
"data": "a\u3002b",
"valid": true
},
{
"description": "fullwidth full stop as label separator",
"data": "a\uff0eb",
"valid": true
},
{
"description": "halfwidth ideographic full stop as label separator",
"data": "a\uff61b",
"valid": true
}
]
}
Expand Down
49 changes: 48 additions & 1 deletion tests/draft2019-09/optional/format/idn-hostname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,58 @@
"description": "empty string",
"data": "",
"valid": false
},
}
]
},
{
"description": "validation of separators in internationalized host names",
"specification": [

Check notice on line 339 in tests/draft2019-09/optional/format/idn-hostname.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://www.rfc-editor.org/rfc/rfc3490.html#section-3.1
{"rfc3490": "3.1", "quote": "Whenever dots are used as label separators, the following characters MUST be recognized as dots: U+002E (full stop), U+3002 (ideographic full stop), U+FF0E (fullwidth full stop), U+FF61(halfwidth ideographic full stop)"}
],
"schema": {
"$schema": "https://json-schema.org/draft/2019-09/schema",
"format": "idn-hostname"
},
"tests": [
{
"description": "single dot",
"data": ".",
"valid": false
},
{
"description": "single ideographic full stop",
"data": "\u3002",
"valid": false
},
{
"description": "single fullwidth full stop",
"data": "\uff0e",
"valid": false
},
{
"description": "single halfwidth ideographic full stop",
"data": "\uff61",
"valid": false
},
{
"description": "dot as label separator",
"data": "a.b",
"valid": true
},
{
"description": "ideographic full stop as label separator",
"data": "a\u3002b",
"valid": true
},
{
"description": "fullwidth full stop as label separator",
"data": "a\uff0eb",
"valid": true
},
{
"description": "halfwidth ideographic full stop as label separator",
"data": "a\uff61b",
"valid": true
}
]
}
Expand Down
49 changes: 48 additions & 1 deletion tests/draft2020-12/optional/format/idn-hostname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,58 @@
"description": "empty string",
"data": "",
"valid": false
},
}
]
},
{
"description": "validation of separators in internationalized host names",
"specification": [

Check notice on line 339 in tests/draft2020-12/optional/format/idn-hostname.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://www.rfc-editor.org/rfc/rfc3490.html#section-3.1
{"rfc3490": "3.1", "quote": "Whenever dots are used as label separators, the following characters MUST be recognized as dots: U+002E (full stop), U+3002 (ideographic full stop), U+FF0E (fullwidth full stop), U+FF61(halfwidth ideographic full stop)"}
],
"schema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"format": "idn-hostname"
},
"tests": [
{
"description": "single dot",
"data": ".",
"valid": false
},
{
"description": "single ideographic full stop",
"data": "\u3002",
"valid": false
},
{
"description": "single fullwidth full stop",
"data": "\uff0e",
"valid": false
},
{
"description": "single halfwidth ideographic full stop",
"data": "\uff61",
"valid": false
},
{
"description": "dot as label separator",
"data": "a.b",
"valid": true
},
{
"description": "ideographic full stop as label separator",
"data": "a\u3002b",
"valid": true
},
{
"description": "fullwidth full stop as label separator",
"data": "a\uff0eb",
"valid": true
},
{
"description": "halfwidth ideographic full stop as label separator",
"data": "a\uff61b",
"valid": true
}
]
}
Expand Down
46 changes: 45 additions & 1 deletion tests/draft7/optional/format/idn-hostname.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,55 @@
"description": "empty string",
"data": "",
"valid": false
},
}
]
},
{
"description": "validation of separators in internationalized host names",
"specification": [

Check notice on line 331 in tests/draft7/optional/format/idn-hostname.json

View workflow job for this annotation

GitHub Actions / annotate

Specification Link 

https://www.rfc-editor.org/rfc/rfc3490.html#section-3.1
{"rfc3490": "3.1", "quote": "Whenever dots are used as label separators, the following characters MUST be recognized as dots: U+002E (full stop), U+3002 (ideographic full stop), U+FF0E (fullwidth full stop), U+FF61(halfwidth ideographic full stop)"}
],
"schema": { "format": "idn-hostname" },
"tests": [
{
"description": "single dot",
"data": ".",
"valid": false
},
{
"description": "single ideographic full stop",
"data": "\u3002",
"valid": false
},
{
"description": "single fullwidth full stop",
"data": "\uff0e",
"valid": false
},
{
"description": "single halfwidth ideographic full stop",
"data": "\uff61",
"valid": false
},
{
"description": "dot as label separator",
"data": "a.b",
"valid": true
},
{
"description": "ideographic full stop as label separator",
"data": "a\u3002b",
"valid": true
},
{
"description": "fullwidth full stop as label separator",
"data": "a\uff0eb",
"valid": true
},
{
"description": "halfwidth ideographic full stop as label separator",
"data": "a\uff61b",
"valid": true
}
]
}
Expand Down
Loading