Skip to content

Fix github action Close Completed Issues running with errors for the last weeks. #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 11, 2023

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Aug 29, 2023

GitHub Issue: NA

Summary: For the last weeks the action to close completed issues is reporting an error. This PR is intended to solve the situatiom.

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No. This is just a fix of an existing issue.

benjagm added 12 commits August 29, 2023 12:29
Added more tracing for better debugging.
Some changes to simplify code.
Remove unnecessary curly brackets.
More changes in the tracing strategy.
Testing different way to update the issue.
Error with variable setup.
More changes in the tracing strategy.
Change how we manage the input parameters for updating the issues.
More changes in the tracing strategy.
Fix variable syntax errors when logging.
@benjagm benjagm changed the title Fix Close Completed issues running with errors for the last weeks. Fix github action Close Completed Issues running with errors for the last weeks. Aug 29, 2023
@benjagm benjagm requested a review from Relequestual September 6, 2023 14:31
});
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise looks good.

@benjagm benjagm merged commit 4f6a8b7 into json-schema-org:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants