Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Juan Cruz Viotti to ambassador list #761

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Jun 21, 2024

Not sure if I'm missing anything, but please let me know. Does things like AlterSchema and Learn JSON Schema count?

@Relequestual
Copy link
Member

Not sure if I'm missing anything, but please let me know. Does things like AlterSchema and Learn JSON Schema count?

Yes, they very much count =]

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pleased to formally recognise the work you do and the effort you've put into supporting JSON Schema!

@jviotti
Copy link
Member Author

jviotti commented Jun 21, 2024

Thanks a lot! ❤️

Yes, they very much count =]

@Relequestual Should I add them to this PR?

@jviotti
Copy link
Member Author

jviotti commented Jun 21, 2024

I added them in case you want to re-review

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Juan!!

@benjagm
Copy link
Collaborator

benjagm commented Jul 29, 2024

Hi @jviotti . Can you please resolve the conflict? We'll merge this asap.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the jviotti-ambassor branch from 1a8067b to 8e42cac Compare July 29, 2024 13:38
@jviotti
Copy link
Member Author

jviotti commented Jul 29, 2024

Done @benjagm !

@jviotti
Copy link
Member Author

jviotti commented Jul 29, 2024

Looks like the original JSON, even before this PR, is invalid? Let me fix it here

jviotti added 2 commits July 29, 2024 09:54
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
Copy link
Member Author

jviotti commented Jul 29, 2024

OK @benjagm I also found the previous ambassador entry was not valid according to the schema you had in there. It should be all fixed now

@benjagm benjagm merged commit 6fd093c into json-schema-org:main Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants