-
-
Notifications
You must be signed in to change notification settings - Fork 213
Update example name #70
Comments
Per
I am checking off each one that is reviewed as correct. |
Pull request #71 fixes the first issue. Nearly everything else is OK. Perhaps this example could also be more descriptive: https://github.com/json-schema-org/json-schema-org.github.io/blob/master/latest/json-schema-core.html#L590-L596 {
"title": "root",
"items": {
"title": "array item"
}
} |
@fulldecent see I feel like there are some more issues along these lines but I can't find them right now (there are several regarding default, but fewer regarding title and description). Basically, there's not agreement on what these keywords are really for. Some current project members regularly quote definitions that do not agree with the spec. I'm hoping we can address this soon after we get Draft 06 out the door. For now I would call this blocked on the general confusion over what we are doing with annotation/documentation/comments. |
@fulldecent Really appreciate your effort on this. I'm not as reserved as @handrews on this one, but if he says we should wait, then we should. |
Use descriptive title in example, fixes #70
Thank you. Next PR coming to fix the remaining one. |
Done. That is the last remaining one. |
Use descriptive title in example, fixes #70
This regards examples.html and perhaps other examples.
I am just starting to learn about JSON Schema and read the first example:
The
title
attribute is defined in http://json-schema.org/latest/json-schema-validation.html#rfc.section.6.1 as:In light of this, the example's
title
seems incorrect because it is describing the schema itself rather than the JSON instance that is being validated.Recommended change:
The text was updated successfully, but these errors were encountered: