Skip to content

Support for adding multiple levels of validation errors #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevengoossensB opened this issue Jan 31, 2023 · 2 comments
Closed

Support for adding multiple levels of validation errors #1377

stevengoossensB opened this issue Jan 31, 2023 · 2 comments

Comments

@stevengoossensB
Copy link

As already discussed in #270 , I think there should be functionality to make a distinction between an ERROR (e.g. breaking a build) and a WARNING (something that should be changed in metadata, not blocking problem).

I would add a key errorLevel, with levels "error", "warning", "deprecated" and add this to the validation errors.

@gregsdennis
Copy link
Member

Hi, thanks for bringing this back up. It's been a while and revisiting old topics is often useful.

I'm actually the primary member leading the effort for the specified output formats. You can follow the output label to see relevant issues.

I think my stance as stated in that issue remains unchanged. Essentially, feel that "error level" is an application-level concern. Different applications will have different priorities for the errors, and it's their responsibility to interpret what a validation returns.

Also, with the output format that is now specified, applications have much more information available to make that determination than they did when that issue was active.

I don't think the specification has the purview to determine for everyone which errors can be considered warnings or critical. We just report that something didn't match what was expected and leave interpretation to the consumer.

@gregsdennis
Copy link
Member

Closing for now as I don't see an action here. Happy to reopen after further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants