Disallow fragments in "$id" #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2022
gregsdennis
approved these changes
Sep 18, 2022
jdesrosiers
approved these changes
Sep 21, 2022
karenetheridge
approved these changes
Oct 6, 2022
notEthan
added a commit
to notEthan/JSON-Schema-Test-Suite
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "$id" side of #1059, as @jdesrosiers was the only objector to that part and eventually dropped his alternate proposal.
Note that, syntactically, this is backwards-incompatible, but it is a change that we warned about in the CREF for the last three I-D publications, which ought to be sufficient warning.