-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1402: clarify readOnly
applies to any value, not just properties
#1522
Fixes #1402: clarify readOnly
applies to any value, not just properties
#1522
Conversation
…ot just properties). Format `true` and `false` code values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and for taking the time to do the additional cleanup.
jsonschema-validation.md
Outdated
@@ -1,4 +1,4 @@ | |||
# JSON Schema Validation: A Vocabulary for Structural Validation of JSON | |||
e# JSON Schema Validation: A Vocabulary for Structural Validation of JSON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e# JSON Schema Validation: A Vocabulary for Structural Validation of JSON | |
# JSON Schema Validation: A Vocabulary for Structural Validation of JSON |
jsonschema-validation.md
Outdated
instance is managed exclusively by the owning authority, and attempts by an | ||
application to modify the value of this property are expected to be ignored or | ||
application to modify the value of an instance are expected to be ignored or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I read "an instance" my mind went to the "the entire JSON document", which isn't the intention. I think "instance" can be used to refer to a fragment of a JSON document, but we usually don't use it that way so this might be confusing.
What if we just leave it at "the value" and drop the "of" part entirely? Or we could say "that value within an instance"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or "the local instance"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about :
If `readOnly` has a value of boolean `true`, it indicates that the
corresponding value in the instance is
managed exclusively by the owning authority, and attempts by an
application to modify the value are expected to be ignored or
rejected by that owning authority.
is his ready to merge? I'm not sure how to reset the "PR Policy / Require Minimum Open Time (pull_request)" check |
We can rerun it from our end, but you can also close then reopen the PR. It'll fail if the PR hasn't been open for two weeks. It's a policy we've had in place for a long time. |
clarify that
readOnly
applies to any value, not just properties.Re-format
true
andfalse
code valuesResolves #1402