-
-
Notifications
You must be signed in to change notification settings - Fork 308
Validation: Replace "considered present" language #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
awwright
wants to merge
1
commit into
json-schema-org:master
from
awwright:considered-present-considered-harmful
+11
−8
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -331,7 +331,7 @@ | |
Each object MUST be a valid JSON Schema. | ||
</t> | ||
<t> | ||
If absent, it can be considered present with an empty schema. | ||
A missing keyword is the same as an empty schema. | ||
</t> | ||
<t> | ||
This keyword controls child instance validation. Validation of the | ||
|
@@ -353,9 +353,6 @@ | |
The value of "additionalItems" MUST be a boolean or an object. | ||
If it is an object, the object MUST be a valid JSON Schema. | ||
</t> | ||
<t> | ||
If absent, it can be considered present with an empty schema. | ||
</t> | ||
<t> | ||
This keyword controls child instance validation. Validation of the | ||
primitive instance type against this keyword always succeeds. | ||
|
@@ -370,6 +367,9 @@ | |
schema (possibly the default value of an empty schema) is | ||
applied to all elements. | ||
</t> | ||
<t> | ||
A missing keyword is the same as an empty schema. | ||
</t> | ||
</section> | ||
|
||
<section title="maxItems"> | ||
|
@@ -393,7 +393,7 @@ | |
greater than, or equal to, the value of this keyword. | ||
</t> | ||
<t> | ||
If this keyword is not present, it may be considered present with a | ||
A missing keyword is the same as a | ||
value of 0. | ||
</t> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The old language is clearer. In the new it is not clear a value of what. |
||
</section> | ||
|
@@ -408,7 +408,7 @@ | |
successfully if all of its elements are unique. | ||
</t> | ||
<t> | ||
If not present, this keyword may be considered present with boolean | ||
A missing keyword is the same as the | ||
value false. | ||
</t> | ||
</section> | ||
|
@@ -447,7 +447,7 @@ | |
keyword. | ||
</t> | ||
<t> | ||
If this keyword is not present, it may be considered present with a | ||
A mising keyword is the same as a | ||
value of 0. | ||
</t> | ||
</section> | ||
|
@@ -461,6 +461,9 @@ | |
An object instance is valid against this keyword if its | ||
property set contains all elements in this keyword's array value. | ||
</t> | ||
<t> | ||
A missing keyword is the same as an empty array. | ||
</t> | ||
</section> | ||
|
||
<section title="properties"> | ||
|
@@ -510,7 +513,7 @@ | |
object. If it is an object, the object MUST be a valid JSON Schema. | ||
</t> | ||
<t> | ||
If "additionalProperties" is absent, it may be considered present with | ||
A missing keyword is the same as | ||
an empty schema as a value. | ||
</t> | ||
<t> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New wording is more ambiguous than the old.