Control link applicability with "hrefRequired" #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
changed the title
dlax
approved these changes
Sep 13, 2017
jsonschema-hyperschema.xml
Outdated
| but no such data was provided (or "hrefSchema" is not present), and the | ||
| instance is an array or a string. | ||
| Sometimes, the appropriate values will not be available. In many | ||
| cases, the URI Template behavior of simply removing varibles that |
There was a problem hiding this comment.
I swear I actually do use a spell checker. But so many technical words don't count as spelled right I sometimes miss real errors.
handrews
force-pushed
the
href-req
branch
2 times, most recently
from
9fdd8ef to
441fa3d
Compare
awwright
approved these changes
Sep 18, 2017
This addresses issue json-schema-org#49. Add a keyword, "hrefRequired", that prevents a link from being used if a variable named in that keyword's array cannot be resolved to a value by any available mechanism. Remove outdated language about non-object instances causing problems, as this is addressed by "hrefPointers".
Properly specify the meta-schema, which for some reason was only a description. We don't put descriptions in the meta-schema anymore, but we do put type information. Not sure what happened there.
|
Note: The update to the PR after awwright and dlax's approvals is just a rebase onto master so that the PR is no longer stacked on an older PR. There were no changes to the contents of the commits. |
dlax
reviewed
Sep 19, 2017
links.json
Outdated
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } |
There was a problem hiding this comment.
We could have a "uniqueItems": true here I guess?
There was a problem hiding this comment.
Yeah, good catch, I'll fix that.
dlax
approved these changes
Sep 19, 2017
|
Last call! This goes in tomorrow barring substantial objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This PR has been rebased so that it only contains the new commits. Originally it was posted piggybacking on #386, which has since been accepted.
This addresses issue #49.
Add a keyword, "hrefRequired", that prevents a link from being
used if a variable named in that keyword's array cannot be resolved
to a value by any available mechanism.
Remove outdated language about non-object instances causing problems,
as this is addressed by "hrefPointers".