Skip to content

Add back examples in "JSON Hyper-Schema and HTTP" section #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dlax
Copy link
Member

@dlax dlax commented Nov 3, 2017

Restore examples about targetHints and headerSchema as they were before #427.

These keywords being new and explicitly meant for experimentation and feedback (as noted in CREF), I think it's worth having examples in the specification so that people get clear idea of what they are for.
Also, the introduction of "Examples" section currently states that the section about HTTP contains example, and there are currently none.

dlax added 2 commits November 3, 2017 08:51
…ints" section

Add the example as it was in 1865631
(that is, just before merge of json-schema-org#427 "Rewrite the Hyper-Schema spec
almost entirely").
Add the example as it was in 1865631
(that is, just before merge of json-schema-org#427 "Rewrite the Hyper-Schema spec
almost entirely"). Only added a top-level "headerSchema" key to make it
symmetrical with the "targetHints" above.
@handrews
Copy link
Contributor

handrews commented Nov 6, 2017

Also, the introduction of "Examples" section currently states that the section about HTTP contains example, and there are currently none.

That's because I intended to move these or something like them to that section. I would still prefer that.

@dlax
Copy link
Member Author

dlax commented Nov 6, 2017 via email

@handrews
Copy link
Contributor

handrews commented Nov 6, 2017

Again, gathering other opinions on this "examples" issue would really be beneficial.

I think part of how we do that is we publish the document with the examples done a certain way and see what the response is. From past experience, draft publication definitely does flush out a new round of comments.

I would like to see how a larger audience reacts to an approach where examples are concentrated in one or two sections.

I definitely dropped the ball on this and just forgot to cover it. So you're reacting to a real problem here and I would not expect you to guess my intentions. Let's leave this open for the moment and I'll think about how it should work. I'm not dead set against examples in these sections to the same degree as the introduction, so maybe they will work best here.

@handrews
Copy link
Contributor

handrews commented Nov 7, 2017

Let's fold this into #469 as well, as it is all related in some way to the section that addresses.

@handrews handrews closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants