Fix the confimation dialog box error #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AQIB-NAWAB
changed the title
|
@JeelRajodiya please review the PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where confirmation dialogues remained open after resetting progress. Key changes include removing unused Popover components, replacing the existing state with a dedicated confirmationDialogOpen state, and updating the localStorage removal logic.
Files not reviewed (1)
- app/components/NavBarMenus/NavBar.module.css: Language not supported
Comments suppressed due to low confidence (2)
app/components/NavBarMenus/NavBarMenus.tsx:22
- [nitpick] The function name 'NavBarMenu' does not match the file name 'NavBarMenus.tsx'. Consider renaming the function to 'NavBarMenus' for consistency.
export default function NavBarMenu() {
app/components/NavBarMenus/NavBarMenus.tsx:72
- [nitpick] The check for 'progress' in localStorage is redundant because localStorage.removeItem can be safely called even if the key does not exist. Removing the if statement would simplify the code.
if (localStorage.getItem("progress")) {
JeelRajodiya
requested changes
Mar 31, 2025
There was a problem hiding this comment.
Why are we creating a new css file? please do not modify the designs of the components. only include the relevant changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix
Issue Number:
Screenshots/videos:
Screencast.from.2025-03-26.23-33-51.webm
Summary
Resolve the issue of confirmation dialogues remains open when we close the reset ones.
Does this PR introduce a breaking change?
No