-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Author Rendering at the Blog page #1066
base: main
Are you sure you want to change the base?
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ritesh2351235 pls. remove the changes associated with /community folder. Here its used as git submodule thus if you wanna perform any change in it you have to open a PR in https://github.com/json-schema-org/community/ repo
b19edd3
to
97b6cc3
Compare
@DhairyaMajmudar I think the changes are working fine now. |
@Ritesh2351235 is earlier commit the changes were related to some other lines of code. Can you pls. check that. |
@DhairyaMajmudar I have removed those changes, there was a problem while rebasing the repo |
@DhairyaMajmudar Can you just check with the production code theater the authors are rendering correctly in the blog page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className={`
bg-slate-50
rounded-full
-ml-3
bg-cover
bg-center
border-2
border-white
${sizeClass}`}
True @Ritesh2351235 on production website the bug is now not showing but its seems like the bug mentioned arises in some special cases. The styles affecting the authors' images are joined using array methods which is quite strange. |
@DhairyaMajmudar Hey the Code is working fine now, but I still can't figure out why the code breaks at the production. |
I think the styles are not working because of the Tailwind styles purge process. Specifically, we should avoid using string concatenation to create class names: https://v2.tailwindcss.com/docs/optimizing-for-production#writing-purgeable-html See #1029 (review) |
@DhairyaMajmudar Went through all the Documentation and this should solve the problem now !! |
What kind of change does this PR introduce?
Changing the styling in the Blog page to avoid conflicts with the PurgeCSS.
Issue Number: