Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Author Rendering at the Blog page #1066

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Ritesh2351235
Copy link
Contributor

What kind of change does this PR introduce?
Changing the styling in the Blog page to avoid conflicts with the PurgeCSS.

Issue Number:

@Ritesh2351235 Ritesh2351235 requested a review from a team as a code owner October 26, 2024 10:03
Copy link

github-actions bot commented Oct 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6c5c495

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (718dab5) to head (6c5c495).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1066   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24 label Oct 26, 2024
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ritesh2351235 pls. remove the changes associated with /community folder. Here its used as git submodule thus if you wanna perform any change in it you have to open a PR in https://github.com/json-schema-org/community/ repo

_includes/community Outdated Show resolved Hide resolved
@Ritesh2351235
Copy link
Contributor Author

@DhairyaMajmudar I think the changes are working fine now.

@DhairyaMajmudar
Copy link
Member

@Ritesh2351235 is earlier commit the changes were related to some other lines of code. Can you pls. check that.

@Ritesh2351235
Copy link
Contributor Author

Ritesh2351235 commented Oct 27, 2024

@DhairyaMajmudar I have removed those changes, there was a problem while rebasing the repo
Now I have only updated the blog page

@Ritesh2351235
Copy link
Contributor Author

@DhairyaMajmudar Can you just check with the production code theater the authors are rendering correctly in the blog page?
Let me know if any changes are required.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

className={`
                                      bg-slate-50
                                      rounded-full
                                      -ml-3
                                      bg-cover
                                      bg-center
                                      border-2
                                      border-white 
                                      ${sizeClass}`}

@DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar Can you just check with the production code theater the authors are rendering correctly in the blog page? Let me know if any changes are required.

True @Ritesh2351235 on production website the bug is now not showing but its seems like the bug mentioned arises in some special cases. The styles affecting the authors' images are joined using array methods which is quite strange.
Let's replace them with the string literals as I've shown in this comment #1066 (review)

@Ritesh2351235
Copy link
Contributor Author

@DhairyaMajmudar Hey the Code is working fine now, but I still can't figure out why the code breaks at the production.
Can we move forward with this now?

@benjagm
Copy link
Collaborator

benjagm commented Nov 8, 2024

I think the styles are not working because of the Tailwind styles purge process. Specifically, we should avoid using string concatenation to create class names:

https://v2.tailwindcss.com/docs/optimizing-for-production#writing-purgeable-html

See #1029 (review)

@Ritesh2351235
Copy link
Contributor Author

@DhairyaMajmudar Went through all the Documentation and this should solve the problem now !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Blog Page Author rendering problem
3 participants