Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regular_expressions.md #1115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Vaent
Copy link

@Vaent Vaent commented Nov 14, 2024

Identify the schema for the last example.
Identify the compliant and noncompliant data.
Make indentation consistent with the example above it.

What kind of change does this PR introduce?

Issue Number:

  • Closes #___
  • Related to #___
  • Others?

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Identify the schema for the last example.
Identify the compliant and noncompliant data.
Make indentation consistent with the example above it.
@Vaent Vaent requested a review from a team as a code owner November 14, 2024 12:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Nov 14, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d376188

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9899bc7) to head (d376188).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregsdennis
Copy link
Member

@Vaent please update your opening comment to include relevant issue numbers where this change has been discussed.

This was referenced Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants