feat: Add links to similar technologies (#126) #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Great job here @Michael-Obele !! Just left some comments and suggestions but we are very close!
Excellent job.
benjagm
added
the
Status: In Progress
|
Thank you for taking the time to look over my work. I appreciate your feedback and have made the necessary improvements. |
benjagm
approved these changes
Mar 1, 2024
benjagm
added
Status: Review Needed
Thanks, glad to help. |
benjagm
requested changes
Mar 1, 2024
Co-authored-by: Benjamin Granados <40007659+benjagm@users.noreply.github.com>
|
@benjagm I just made the changes; what do you think? |
benjagm
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #126
Summary: Adds a new page "Links to similar technologies" in the overview section.
Do you think resolving this issue might require an Architectural Decision Record (ADR) (https://github.com/json-schema-org/community/blob/main/CONTRIBUTING.md#key-architectural-decisions)? (significant or noteworthy)
No
Justification: This change introduces a new page in the documentation listing existing technologies similar to JSON Schema. The page provides context and resources for users who want to explore alternative approaches to data validation and description. This addition primarily involves adding content and linking to existing resources, and does not significantly impact the overall architecture of the codebase. Therefore, an Architectural Decision Record (ADR) is not considered necessary for this specific change.